Skip to content

Fixed non-escaped *s in grammar #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2018

Conversation

brauliobz
Copy link
Contributor

Those break mbook's parsing sometimes.

@Havvy
Copy link
Contributor

Havvy commented Mar 12, 2018

How do these break mdbook's parsing? Is it a Mardown thing, or an issue in mdbook?

@brauliobz
Copy link
Contributor Author

@Havvy an example:

Text 1

> Text 2 <sup>*</sup> Text 3  
> Text 4  

Text 5

> Text 6 <sup>*</sup> Text 7  
> Text 8  

Text 9

is rendered by mdbook as:

Text 1

Text 2 Text 3
Text 4 Text 7
Text 8

Text 9

Notice the missing Text 5 and Text 6, and the italicized Text 3 and Text 4.
The github markdown engine renders it correctly:

Text 1

Text 2 * Text 3
Text 4

Text 5

Text 6 * Text 7
Text 8

Text 9

@matthewjasper
Copy link
Contributor

@brauliobz, can you rebase so that this can be merged, unless @Havvy has any objections.

@brauliobz
Copy link
Contributor Author

@matthewjasper Done.

@matthewjasper matthewjasper merged commit 19dd3dd into rust-lang:master Mar 29, 2018
@matthewjasper
Copy link
Contributor

Thanks!

@brauliobz brauliobz deleted the little_fix branch March 29, 2018 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants