Skip to content

Add new temporary lifetime extension rule #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Add new temporary lifetime extension rule #1813

merged 1 commit into from
Jun 24, 2025

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented May 7, 2025

@rustbot rustbot added the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label May 7, 2025
@m-ou-se
Copy link
Member Author

m-ou-se commented May 7, 2025

@WaffleLapkin I vaguely remember you were working on rewriting this section at some point? Maybe I misremember.

@m-ou-se m-ou-se mentioned this pull request May 7, 2025
Merged
@WaffleLapkin
Copy link
Member

I indeed found this message:

[14:11] waffle: thank uuu!! with this knowledge I can document this stuff in the compiler and reference >:3

I did forget about it and can't find any changes I did back then, so I'd assume I haven't even started rewriting it. I'll write this down so I don't forget again ^^'

WaffleLapkin
WaffleLapkin reviewed May 7, 2025
View reviewed changes
@joshtriplett
Copy link
Member

This looks correct to me.

traviscross
traviscross reviewed May 8, 2025
View reviewed changes
traviscross
traviscross reviewed May 8, 2025
View reviewed changes
ehuss
ehuss reviewed May 8, 2025
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the examples below still need updating (just below in the "Examples" section).

@ehuss ehuss added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: The marked PR is awaiting review from a maintainer labels May 8, 2025
@m-ou-se
Copy link
Member Author

m-ou-se commented Jun 13, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: The marked PR is awaiting review from a maintainer and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Jun 13, 2025
@m-ou-se
Copy link
Member Author

m-ou-se commented Jun 13, 2025

This now fails the code tests because rust-lang/rust#140593 (which this PR is trying to document) isn't merged yet.

@ehuss
Copy link
Contributor

ehuss commented Jun 13, 2025

Thanks @m-ou-se! I think this should be ready to merge after rust-lang/rust#140593 merges.

@ehuss ehuss added S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository and removed S-waiting-on-review Status: The marked PR is awaiting review from a maintainer labels Jun 13, 2025
@ehuss ehuss added this pull request to the merge queue Jun 24, 2025
Merged via the queue into rust-lang:master with commit 9571d4d Jun 24, 2025
5 checks passed
@ehuss ehuss mentioned this pull request Jun 25, 2025
Merged
@m-ou-se m-ou-se deleted the tle-tuple branch June 25, 2025 06:08
bors added a commit to rust-lang/rust that referenced this pull request Jun 25, 2025
@bors
Auto merge of #142991 - ehuss:update-beta-cargo, r=ehuss
a8d097a 
[beta] update cargo and reference

## cargo

1 commits in 84709f085062cbf3c51fa507527c1b2334015178..c24e1064277fe51ab72011e2612e556ac56addf7
2025-06-22 23:58:39 +0000 to 2025-06-23 13:53:07 -0700
- [Beta-1.89] Fix potential deadlock in `CacheState::lock` (rust-lang/cargo#15699)

### reference

3 commits in 50fc1628f36563958399123829c73755fa7a8421..9571d4d38cc580bd9fe926f97fccd98f215564a9
2025-06-19 02:02:39 +0000 to 2025-06-24 22:32:56 +0000
- Add new temporary lifetime extension rule (rust-lang/reference#1813)
- Fix smart punctuation inside grammar terminals (rust-lang/reference#1869)
- Fix placement of codegen link definitions (rust-lang/reference#1868)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss left review comments

@WaffleLapkin WaffleLapkin WaffleLapkin left review comments

@traviscross traviscross traviscross approved these changes

Assignees
No one assigned
Labels
S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@m-ou-se @WaffleLapkin @joshtriplett @ehuss @traviscross @rustbot