Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

Conversation

listochkin
Copy link
Contributor

When Brian did the documentation page overhaul he made most links in it bold. However, on OS X these small bold letters look fuzzy and are harder to read. The problem is more apparent in Firefox that tends to render glyph strokes wider than other browsers. Here I've put up the page fragment showing bold and regular fonts being used for links as it's rendered on my machine:

Firefox render for bold and regular links

Also, other pages on Rust website don't use bold for links within text body, and as it is now the documentation page looks out of place.

I know that the whole thing is highly subjective, so if Brian or anyone else feels strongly about the new style I won't mind. Thanks for great work!

When Brian did [the documentation page overhaul](rust-lang@893021c) he made most links in it bold. However, on OS X these small bold letters look fuzzy and are harder to read. The problem is more apparent in Firefox that tends to render glyph strokes wider than other browsers. Here I've put up the page fragment showing bold and regular fonts being used for links as it's rendered on my machine:

![Firefox render for bold and regular links](http://snappyimages.nextwavesrl.netdna-cdn.com/img/1391a2e656bb13ea307c354914fc3109.png)

Also, other pages on Rust website don't use bold for links within text body, and as it is now the documentation page looks out of place.

I know that the whole thing is highly subjective, so if Brian or anyone else feels strongly about the new style I won't mind. Thanks for great work!
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@brson
Copy link
Contributor

brson commented Jan 15, 2016

Thanks.

The reason they are bold is that I'm thinking of them not just as links but as the titles of entries in a list - the bold is the style of the list.

This is also done on the contributing page, so if changed in one place it should be in both. I rather like the way the contributing page looks though.

I definitely want to remove the bold from the first mention of the book on this page, to give the bold links more weight, like on the contributing page.

The documentation page looks good to me with or without the bold, but with my fondness for the contributing page, I'm on the fence. I'm going to sleep on it.

This might be solved by tweaking the font without removing the boldness. I don't notice fuzziness on Firefox on Windows.

cc @aturon @steveklabnik @AndrewBrinker @bjz you might have opinions on whether to use bold links on the doc and contributing page lists.

Doc page without bold.

Contrib page without bold.

@alilleybrinker
Copy link
Contributor

Fira Sans has a bit of a beefy bold. There should be a nice middle ground of using font-weight: 600 instead of the usual font-weight: 700. That way it's bolded, but not as harshly as it is now.

@alilleybrinker
Copy link
Contributor

Huh. It doesn't look like the font is served at a semibold weight. I'll see if something else looks better.

@brendanzab
Copy link

I agree with the removal of the use of a normal weight for small font sizes - this looks much easier to read, because the counters are more open. There is also enough hierarchy present in the different colour as opposed to the body text - making the links bold as well makes it seem a tad busy.

brson added a commit that referenced this pull request Jan 21, 2016
Removed bold from links to improve readability
@brson brson merged commit b46a3e8 into rust-lang:master Jan 21, 2016
@brson
Copy link
Contributor

brson commented Jan 21, 2016

Thanks @listochkin @AndrewBrinker @bjz.

I'm merging this on its own merits and will think about #279 separately.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants