Strengthen warnings about relying on Mask layout #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebzulawski
requested changes
Jul 1, 2022
thomcc
force-pushed
the
stronger-warnings-about-layout
branch
from
273b392 to
b0e6d27
Compare
calebzulawski
approved these changes
Jul 21, 2022
|
Thank you for following up on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more clear that you can't rely on the layout of these, which seems worth doing given that the names vaguely suggest that you can (and the docs only clarify that you can't on
Maskbut not themaskNxMaliases).Not tied to the specific wording here, and I'm not sure that it's actually worth clarifying that "yes, this includes
[iN; M]", so I'm open to rewording. I do think we should have the caveat on the type aliases as well, though.