Skip to content

Conversation

RalfJung
Copy link
Member

With rust-lang/rust#146207 finally switching to a provenance-compatible API, this can now be made to work.

@rustbot
Copy link
Collaborator

rustbot commented Sep 12, 2025

Thank you for contributing to Miri!
Please remember to not force-push to the PR branch except when you need to rebase due to a conflict or when the reviewer asks you for it.

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Sep 12, 2025
@RalfJung RalfJung enabled auto-merge September 12, 2025 15:09
@RalfJung RalfJung added this pull request to the merge queue Sep 12, 2025
Merged via the queue into rust-lang:master with commit 71c8206 Sep 12, 2025
12 checks passed
@RalfJung RalfJung deleted the wasip2-helloworld branch September 12, 2025 16:10
@rustbot rustbot removed the S-waiting-on-review Status: Waiting for a review to complete label Sep 12, 2025
}
// We don't actually close these FDs, so this is a NOP.
}
"[method]output-stream.blocking-write-and-flush" => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found https://wasmcloud.com/docs/reference/wasi/interfaces/ but that uses higher-level types, so I ended up reversing this based on the file you linked.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The high level interfaces are specified in https://github.com/WebAssembly/WASI/tree/main/wasip2 The exact symbol names are merely a contract between wit-bindgen and wasm-tools component new. They are not part of the ABI after linking. Based on bytecodealliance/wasm-tools#1828 it seems that wit-bindgen is going to change the used names in the future once wasm-tools versions with support for the new naming scheme are old enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants