ManuallyDrop::new -> forget where possible #1527
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know if this is actually the fix, but it seems like the only thing if my change actually caused the toolstate break.
|
|
|
The only file that failed testing is |
|
Oh, probably you were confused because the bot attributed the wrong PR. rust-lang/rust#75912 didn't break Miri, rust-lang/rust#75687 did. I'll close this PR and work on a fix. Thanks for helping to keep Miri working! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rust-lang/rust#75912 it said that I broke miri. I'm not sure how, but this is my best guess.
Feel free to take or leave this PR as you wish.