lvalue references into fields of ValPair locals #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solson
reviewed
Feb 10, 2017
src/eval_context.rs
Outdated
| let mut allocs = Vec::new(); | ||
| let mut msg = format!("{:?}", local); | ||
| let last_frame = self.stack.len() - 1; | ||
| if frame != last_frame { | ||
| write!(msg, " ({} frames up)", last_frame - frame).unwrap(); | ||
| } | ||
| if let Some(field) = field { | ||
| write!(msg, " (field {:?})", field).unwrap(); |
There was a problem hiding this comment.
Can you print it like {local}.{field}, e.g. _42.1: Bytes(13)?
| return Ok(base); | ||
| }, | ||
| Value::ByValPair(_, _) => { | ||
| assert!(field_index < 2); |
There was a problem hiding this comment.
How do we know this won't be hit?
There was a problem hiding this comment.
We most likely can hit it with zst fields, but right now we don't create any ByValPairs for custom structs.
solson
reviewed
Feb 10, 2017
src/eval_context.rs
Outdated
| @@ -1367,13 +1367,13 @@ impl<'a, 'tcx> EvalContext<'a, 'tcx> { | |||
| if let Lvalue::Local { frame, local, field } = lvalue { | |||
| let mut allocs = Vec::new(); | |||
| let mut msg = format!("{:?}", local); | |||
| if let Some(field) = field { | |||
| write!(msg, ".{}", field).unwrap(); | |||
There was a problem hiding this comment.
This failed to compile, and the error message makes me realize it should only be printing the index part of the field tuple.
erickt
pushed a commit
to erickt/miri
that referenced
this pull request
Feb 4, 2022
Update the README for the hashbrown-based implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran this on the rustc test suite and found no regressions, but your changes also came in there (and reduced the number of errors significantly), so maybe I don't see something.
more groundwork towards