Reorganize shims by platform #1167
Conversation
pvdrz
force-pushed
the
shims-refactor
branch
2 times, most recently
from
08afbf1 to
eb86c57
Compare
|
This is still marked as WIP... are there still questions about which platform some shims belong to? |
Yes, I'll do a list in the first comment to track them |
|
Also I'm not sure what to do with the |
|
☔ The latest upstream changes (presumably #1159) made this pull request unmergeable. Please resolve the merge conflicts. |
Seems fine to me to just have both of them on all platforms, TBH. |
All the pthreads ones are POSIX.The rest are weird ones I mostly had to add to get the stack guard page setup to go through; you can grep for them in libstd to see on which platforms they get used. |
|
OK, this is no longer a draft :P |
|
☔ The latest upstream changes (presumably #1158) made this pull request unmergeable. Please resolve the merge conflicts. |
pvdrz
force-pushed
the
shims-refactor
branch
from
bba64b4 to
3ab93ad
Compare
|
Let's see if this works on Windows. @bors try |
pvdrz
force-pushed
the
shims-refactor
branch
from
69ef4ad to
bb3a711
Compare
|
@bors try |
Reorganize shims by platform Fixes #1161. I am currently testing which shims belong to which platform. If you are reading this and know the answer for any of those please write me :P Edit: this is a list of the shims I haven't been able to figure out to which platform they belong: -~~`malloc`~~ -~~`calloc`~~ -~~`posix_memalign`~~ -~~`free`~~ -~~`realloc`~~ -~~`__rust_alloc`~~ -~~`__rust_alloc_zeroed`~~ -~~`__rust_dealloc`~~ -~~`__rust_realloc`~~ -~~`__rust_maybe_catch_panic`~~ -~~`syscall`~~ -~~`getrandom`~~ -~~`dlsym`~~ -~~`memcmp`~~ -~~`memrchr`~~ -~~`memchr`~~ -~~`strlen`~~ -~~`signal`~~ -~~`sigaction`~~ -~~`sigaltstack`~~ -~~`sysconf`~~ -~~`sched_getaffinity`~~ -~~`isatty`~~ -~~`pthread_key_create`~~ -~~`pthread_key_delete`~~ -~~`pthread_getspecific`~~ -~~`pthread_setspecific`~~ -~~`pthread_attr_init`~~ -~~`pthread_attr_destroy`~~ -~~`pthread_self`~~ -~~`pthread_attr_setstacksize`~~ -~~`pthread_attr_getstack`~~ -~~`pthread_create`~~ -~~`pthread_mutexattr_init`~~ -~~`pthread_mutexattr_settype`~~ -~~`pthread_mutex_init`~~ -~~`pthread_mutexattr_destroy`~~ -~~`pthread_mutex_lock`~~ -~~`pthread_mutex_unlock`~~ -~~`pthread_mutex_destroy`~~ -~~`pthread_rwlock_rdlock`~~ -~~`pthread_rwlock_unlock`~~ -~~`pthread_rwlock_wrlock`~~ -~~`pthread_rwlock_destroy`~~ -~~`pthread_condattr_init`~~ -~~`pthread_condattr_setclock`~~ -~~`pthread_cond_init`~~ -~~`pthread_condattr_destroy`~~ -~~`pthread_cond_destroy`~~ -~~`pthread_atfork`~~ -~~`posix_fadvise`~~ -~~`mmap`~~ -~~`mprotect`~~
|
☀️ Try build successful - checks-travis, status-appveyor |
|
Awesome, thanks a lot! @bors r+ |
|
📌 Commit 2086658 has been approved by |
|
☀️ Test successful - checks-travis, status-appveyor |
Fixes #1161. I am currently testing which shims belong to which platform. If you are reading this and know the answer for any of those please write me :P
Edit: this is a list of the shims I haven't been able to figure out to which platform they belong:
-
malloc-
calloc-
posix_memalign-
free-
realloc-
__rust_alloc-
__rust_alloc_zeroed-
__rust_dealloc-
__rust_realloc-
__rust_maybe_catch_panic-
syscall-
getrandom-
dlsym-
memcmp-
memrchr-
memchr-
strlen-
signal-
sigaction-
sigaltstack-
sysconf-
sched_getaffinity-
isatty-
pthread_key_create-
pthread_key_delete-
pthread_getspecific-
pthread_setspecific-
pthread_attr_init-
pthread_attr_destroy-
pthread_self-
pthread_attr_setstacksize-
pthread_attr_getstack-
pthread_create-
pthread_mutexattr_init-
pthread_mutexattr_settype-
pthread_mutex_init-
pthread_mutexattr_destroy-
pthread_mutex_lock-
pthread_mutex_unlock-
pthread_mutex_destroy-
pthread_rwlock_rdlock-
pthread_rwlock_unlock-
pthread_rwlock_wrlock-
pthread_rwlock_destroy-
pthread_condattr_init-
pthread_condattr_setclock-
pthread_cond_init-
pthread_condattr_destroy-
pthread_cond_destroy-
pthread_atfork-
posix_fadvise-
mmap-
mprotect