skip all of sys:: #104
Merged
skip all of sys:: #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the README be updated as well, which also gives a sys subpath? |
|
Good point. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 6, 2025
miri std tests: skip all of sys:: Matches rust-lang/miri-test-libstd#104
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Sep 6, 2025
Rollup merge of #146266 - RalfJung:miri-nosys, r=jieyouxu miri std tests: skip all of sys:: Matches rust-lang/miri-test-libstd#104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's now
sys::platform_versionand who knows what else will show up there -- as the name suggests, it's all very platform-specific, so Miri will not support a lot of it.