collect all test failures before failing #1313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
approved these changes
Sep 6, 2020
Contributor
ehuss
left a comment
ehuss
left a comment
There was a problem hiding this comment.
Thanks! I have kinda wanted this in the past, too. I made a small wording change, which looked like maybe a typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that iterating on
mdbooktest is fairly slow as any failure in any file halts the processThis prints the error with
error~, marks a failure, and then moves onI tested that the return code is 0 on a passing book (i had a working local version of the cargo book) and that its non-0 on a non-passing book (
dummy_bookintestsis good for this)