Self-host fonts, add option to not copy to directory #1189
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vendors Open Sans and Source Code Pro as woff/woff2, adds respective licenses for each.
Supports character sets for:
- `open-sans-v17-latin_vietnamese_latin-ext_greek-ext_greek_cyrillic-ext_cyrillic`
- `source-code-pro-v11-latin_vietnamese_latin-ext_greek_cyrillic-ext_cyrillic`
Add option to disable inclusion of woff/woff2
Open Sans is licensed under Apache 2.0, Source Code Pro is licensed under SIL Open Font License.
|
Fixed via #1188. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendors Open Sans and Source Code Pro as woff/woff2, adds respective licenses for each.
Supports character sets for:
-
open-sans-v17-latin_vietnamese_latin-ext_greek-ext_greek_cyrillic-ext_cyrillic-
source-code-pro-v11-latin_vietnamese_latin-ext_greek_cyrillic-ext_cyrillicAdd option to disable inclusion of woff/woff2
Open Sans is licensed under Apache 2.0, Source Code Pro is licensed under SIL Open Font License. The fonts were downloaded with google-webfonts-helper.
I added controls to the HTML config struct to make the fonts optional. By default, the fonts are enabled with both woff2/woff files. Users can disable the self-hosted fonts, or disable only the woff format files which are supported by older browsers and larger in size.