procctl for freebsd 15 upgrade. #4657
Conversation
devnexen
force-pushed
the
procctl_update
branch
from
e44b6d0 to
17b153c
Compare
adding missing PROC_SPROTECT helpers while at it. ref: https://github.com/freebsd/freebsd-src/blob/c992ac6213276f54d868f317cc5092f8aed4ff54/sys/sys/procctl.h#L68
|
Could you please rebase on the latest commit of the main branch? This will resolve some unrelated FreeBSD CI failures and thus make the CI results clearer.
c992ac6213276f54d868f317cc5092f8aed4ff54 seems to be a rather arbitrary recent commit. I'd suggest linking dabf006a638fdc44cdcf69731de8ac83959db731 instead, which is the commit that introduced the new constants. |
| @@ -3012,6 +3012,11 @@ pub const PROC_NO_NEW_PRIVS_STATUS: c_int = 20; | |||
| pub const PROC_WXMAP_CTL: c_int = 21; | |||
| pub const PROC_WXMAP_STATUS: c_int = 22; | |||
| pub const PROC_PROCCTL_MD_MIN: c_int = 0x10000000; | |||
There was a problem hiding this comment.
I think it's best to keep PROC_PROCCTL_MD_MIN at the end, it doesn't really have a place between PROC_WXMAP_STATUS and PROC_LOGSIGEXIT_CTL in the original headers
| @@ -4788,6 +4793,14 @@ safe_f! { | |||
| pub {const} fn PR_SCTP_VALID_POLICY(x: c_int) -> bool { | |||
| PR_SCTP_POLICY(x) <= SCTP_PR_SCTP_MAX | |||
| } | |||
|
|
|||
| pub {const} fn PPROT_OP(o: c_int) -> c_int { | |||
There was a problem hiding this comment.
I personally would prefer the PPROT changes in a separate commit (same PR is ok), so they can get a more focused commit message (perhaps with a reference link as well)
adding missing PROC_SPROTECT helpers while at it.
ref: https://github.com/freebsd/freebsd-src/blob/c992ac6213276f54d868f317cc5092f8aed4ff54/sys/sys/procctl.h#L68