chore: minor cleanup mode_t usage
#4405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
force-pushed
the
cleaner-mode_t
branch
7 times, most recently
from
3d2493f to
ce240f5
Compare
`crate::mode_t` is almost never needed because it is part of prelude. Moreover, in many cases `mode_t` was already used without the prefix - thus confusing if they are different or not. Keeping it the same helps readability.
tgross35
added
the
stable-nominated
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
May 28, 2025
`crate::mode_t` is almost never needed because it is part of prelude. Moreover, in many cases `mode_t` was already used without the prefix - thus confusing if they are different or not. Keeping it the same helps readability. (backport <rust-lang#4405>) [ Resolve conflict around vxworks S_* constants - Trevor ] (cherry picked from commit 1984cc2)
Merged
tgross35
added
stable-applied
DorianNiemiecSVRJS
pushed a commit
to DorianNiemiecSVRJS/rust-libc
that referenced
this pull request
Jun 21, 2025
`crate::mode_t` is almost never needed because it is part of prelude. Moreover, in many cases `mode_t` was already used without the prefix - thus confusing if they are different or not. Keeping it the same helps readability. (backport <rust-lang#4405>) [ Resolve conflict around vxworks S_* constants - Trevor ] (cherry picked from commit 1984cc2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crate::mode_tis almost never needed because it is part of prelude. Moreover, in many casesmode_twas already used without the prefix - thus confusing if they are different or not. Keeping it the same helps readability.@rustbot label +stable-nominated