Skip to content

Conversation

nathaniel-bennett
Copy link
Contributor

Resolves #1618

It seems like #1618 has already been mostly resolved; this PR simply adds some of the few pthread APIs that are still missing.

@rustbot
Copy link
Collaborator

rustbot commented Aug 17, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@nathaniel-bennett nathaniel-bennett force-pushed the apple-pthread-api branch 9 times, most recently from c2083a9 to 1315359 Compare August 17, 2024 15:51
@nathaniel-bennett
Copy link
Contributor Author

r? @tgross35

@rustbot rustbot assigned tgross35 and unassigned JohnTitor Aug 31, 2024
Comment on lines 73 to 78
f.debug_struct("pthread_attr_t")
f.debug_struct("pthread_once_t")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might not have been intentional

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed--thanks for catching this!

@tgross35
Copy link
Contributor

tgross35 commented Sep 1, 2024

Sources for future reference:

One fix above, then could you define __PTHREAD_ONCE_SIZE__ and make use of it in __opaque (rather than literals) like the definition? We already have e.g. __PTHREAD_RWLOCKATTR_SIZE__ defined, just unfortunately don't use them consistently.

@tgross35 tgross35 added stable-nominated This PR should be considered for cherry-pick to libc's stable release branch S-waiting-on-author and removed S-waiting-on-review labels Sep 1, 2024
@nathaniel-bennett nathaniel-bennett force-pushed the apple-pthread-api branch 2 times, most recently from 445deba to 8cb6396 Compare September 6, 2024 20:11
@nathaniel-bennett
Copy link
Contributor Author

nathaniel-bennett commented Sep 6, 2024

@rustbot label -S-waiting-on-author S-waiting-on-review

@tgross35 tgross35 added this pull request to the merge queue Oct 14, 2024
Merged via the queue into rust-lang:main with commit e715762 Oct 14, 2024
41 checks passed
@nathaniel-bennett nathaniel-bennett deleted the apple-pthread-api branch October 14, 2024 12:03
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 15, 2024
(backport <rust-lang#3846>)
(cherry picked from commit 7b0b1a8)
@tgross35 tgross35 mentioned this pull request Oct 15, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Oct 15, 2024
AkhilTThomas pushed a commit to AkhilTThomas/libc that referenced this pull request Feb 5, 2025
(backport <rust-lang#3846>)
(cherry picked from commit 7b0b1a8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add posix threads support for macOS
4 participants