Skip to content

Conversation

@TheJonny
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@TheJonny
Copy link
Contributor Author

O_SEARCH = (0x40000000 | 0x00100000) does the right thing on macos 13, but on macos 12 the read permission for the directory is still checked on opening, so i think it will be ignored there. (tried on github actions, as I don't own an apple device)

if we need a compile time version check to not provide the symbol for macos 12 (older versions are end of life), I currently don't know how to do it, help would be welcome.

@bors
Copy link
Contributor

bors commented Apr 26, 2024

☔ The latest upstream changes (presumably #3631) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnTitor JohnTitor added this pull request to the merge queue Apr 27, 2024
Merged via the queue into rust-lang:main with commit 2fd2b60 Apr 27, 2024
@tgross35 tgross35 added the stable-applied This PR has been cherry-picked to libc's stable release branch label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants