Skip to content

Revive tests for MIPS64 #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2020
Merged

Revive tests for MIPS64 #1941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a87675
Revert "Skip some tests for `mips64(el)-unknown-linux-gnuabi64`"
JohnTitor Oct 19, 2020
003d6ef
Revert "Disable libc-test for MIPS64 for now"
JohnTitor Oct 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/bors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,8 @@ jobs:
i686-unknown-linux-musl,
mips-unknown-linux-gnu,
mips-unknown-linux-musl,
# FIXME: Disabled because of the `relocation truncated to fit` error
# mips64-unknown-linux-gnuabi64,
# mips64el-unknown-linux-gnuabi64,
mips64-unknown-linux-gnuabi64,
mips64el-unknown-linux-gnuabi64,
mipsel-unknown-linux-musl,
powerpc-unknown-linux-gnu,
powerpc64-unknown-linux-gnu,
Expand Down
4 changes: 0 additions & 4 deletions ci/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,6 @@ else

cargo test $opt --manifest-path libc-test/Cargo.toml --target "${TARGET}"

# FIXME: Somehow it now emits errors like:
# `relocation truncated to fit: R_MIPS_GOT_DISP against `fchmod@@GLIBC_2.0'`
if [ "$TARGET" != "mips64el-unknown-linux-gnuabi64" ] && [ "$TARGET" != "mips64-unknown-linux-gnuabi64" ]; then
cargo test $opt --features extra_traits --manifest-path libc-test/Cargo.toml \
--target "${TARGET}"
fi
fi