Skip to content

separate tests #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2018
Merged

separate tests #76

merged 2 commits into from
Oct 2, 2018

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Oct 2, 2018

follow suggestion from #75

@tisonkun tisonkun mentioned this pull request Oct 2, 2018
Closed
KodrAus
KodrAus reviewed Oct 2, 2018
View reviewed changes
Copy link
Contributor

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! I've just left one comment about how we can exclude the test module when we're not running tests.

@KodrAus KodrAus merged commit f558c3c into rust-lang:master Oct 2, 2018
@tisonkun tisonkun deleted the GH-75 branch October 2, 2018 12:47
@KodrAus KodrAus mentioned this pull request May 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KodrAus KodrAus KodrAus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tisonkun @KodrAus