Release 0.3.25 #2654
Merged
Release 0.3.25 #2654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TennyZhuang <[email protected]>
```
warning: unreachable `pub` item
--> futures-util/src/stream/futures_unordered/mod.rs:25:32
|
25 | pub use self::iter::{IntoIter, Iter, IterMut, IterPinMut, IterPinRef};
| --- ^^^^
| |
| help: consider restricting its visibility: `pub(crate)`
|
= help: or consider exporting it for use by other crates
note: the lint level is defined here
--> futures-util/src/lib.rs:11:5
|
11 | unreachable_pub
| ^^^^^^^^^^^^^^^
warning: unreachable `pub` item
--> futures-util/src/stream/futures_unordered/mod.rs:25:38
|
25 | pub use self::iter::{IntoIter, Iter, IterMut, IterPinMut, IterPinRef};
| --- ^^^^^^^
| |
| help: consider restricting its visibility: `pub(crate)`
|
= help: or consider exporting it for use by other crates
```
``` warning: casting to the same type is unnecessary (`usize` -> `usize`) --> futures-util/src/stream/stream/take.rs:57:37 | 57 | let lower = cmp::min(lower, self.remaining as usize); | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.remaining` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default warning: casting to the same type is unnecessary (`usize` -> `usize`) --> futures-util/src/stream/stream/take.rs:60:28 | 60 | Some(x) if x < self.remaining as usize => Some(x), | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.remaining` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast warning: casting to the same type is unnecessary (`usize` -> `usize`) --> futures-util/src/stream/stream/take.rs:61:23 | 61 | _ => Some(self.remaining as usize), | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.remaining` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast ```
* fix soundness hole in join macros add a miri regression test update failing tests (join sizes increased due to fix) * fix `CI / cross test` by ignoring `join_size` and `try_join_size` tests on "non-64-bit pointer" targets (e.g. `i686-unknown-linux-gnu`) (this is the same fix that was also applied in PR #2447)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports:
CloneforDrain#2650Changes:
join!andtry_join!macros (Fix soundness hole in join macros #2649)Cloneforsink::Drain(ImplementCloneforDrain#2650)