Fix edition-changes links #140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Tested with |
Contributor
Author
|
review/merge by @Centril? |
Contributor
|
The reason I haven't checked out / merged this yet is that I'm not sure if the issue here is mdbook 0.1 vs 0.2. we have to make sure everything works with 0.2 before we can update, and only a few hours ago was it even possible to use 0.2 with this at all. So, sorry for the wait, but that's the root issue here. |
Contributor
Author
|
I see. I'm not sure why you say
because I have mdbook v0.2.3 installed locally and that's what I used to verify this. So I'm confused. |
Contributor
|
The edition guide is currently built with 0.1.
… On Feb 5, 2019, at 3:39 PM, Dale Wijnand ***@***.***> wrote:
I see. I'm not sure why you say
only a few hours ago was it even possible to use 0.2 with this at all
because I have mdbook v0.2.3 installed locally and that's what I used to verify this. So I'm confused.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
|
Sorry, even more context:
There are changes between how links work between mdbook 0.1 and 0.2. So, I believe that what exists right now works with 0.1, but since you built with 0.2, they seemed broken.
Upstream builds with 0.1. This updates to the 0.2 style, which works locally but would fail upstream.
Upstream got the ability to build with 0.2 last night.
Does that make sense?
… On Feb 5, 2019, at 3:39 PM, Dale Wijnand ***@***.***> wrote:
I see. I'm not sure why you say
only a few hours ago was it even possible to use 0.2 with this at all
because I have mdbook v0.2.3 installed locally and that's what I used to verify this. So I'm confused.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
Author
|
Yes, thank you, Steve. Sorry for stealing focus. This patch is trivial, I'll assume it'll be subsumed by the upcoming PR to upgrade the edition guide to mdbook 0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138