Skip to content

Worked on vector-related performance #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 31, 2020
Merged

Conversation

Kixiron
Copy link
Member

@Kixiron Kixiron commented Apr 2, 2020

  • Pre-allocated vectors wherever possible in order to reduce the total amount of allocations preformed

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these would be better written as maps IMO.

@Kixiron
Copy link
Member Author

Kixiron commented Apr 3, 2020

Changed the vast majority to maps, some really didn't lend to it

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of comments! Most of them are just nit-picky things, I'm happy to have them addressed in a follow-up PR instead.

@jyn514
Copy link
Member

jyn514 commented Apr 3, 2020

Thanks so much for working on this! Little things like this are easy to forget about but they make a big difference :)

@jyn514
Copy link
Member

jyn514 commented Apr 3, 2020

I would like to add tests for these before merging. See e.g. https://github.com/rust-lang/docs.rs/blob/master/src/web/mod.rs#L617 for examples of how to write tests, and you can visit the pages on docs.rs to see what the expected behavior should be. I know there's a lot of changes, it might be easier to add tests in a separate PR and merge that first.

@jyn514 jyn514 changed the title Worked on vector-related preformace Worked on vector-related performance Apr 9, 2020
@Kixiron
Copy link
Member Author

Kixiron commented Apr 14, 2020

Git hates me and closed on its own

@Kixiron Kixiron reopened this Apr 14, 2020
@jyn514 jyn514 mentioned this pull request Apr 14, 2020
@jyn514
Copy link
Member

jyn514 commented Apr 27, 2020

Status: this needs to be rebased and needs tests to be written.

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little picky on the last review. This looks good once you rebase and address the outstanding comments (I resolved a lot of them). db/file.rs changed a lot in #643 so you might want to make those changes in a follow-up PR instead of trying to rebase.

@Kixiron
Copy link
Member Author

Kixiron commented May 7, 2020

@jyn514 Fixed

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the hard work! Unfortunately I took long enough to review that there are merge conflicts. Once those are resolved (preferably through rebasing, not merging) this looks great.

@Kixiron Kixiron force-pushed the need-for-sneed branch 2 times, most recently from 4d00880 to b50f3f7 Compare May 27, 2020 17:46
@jyn514 jyn514 merged commit 4dc57be into rust-lang:master May 31, 2020
@jyn514
Copy link
Member

jyn514 commented May 31, 2020

🎉 🎉

@Kixiron Kixiron deleted the need-for-sneed branch May 31, 2020 02:30
jyn514 added a commit to jyn514/docs.rs that referenced this pull request Jun 11, 2020
This was a regression introduced in rust-lang#692.
jyn514 added a commit that referenced this pull request Jun 11, 2020
This was a regression introduced in #692.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants