Remove unused rule from stylesheet #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rules matching a `footer` tag were originally there for styling of a sponsor logo (as shown by `git blame`) on crates.fyi. None of the templates output a `footer` tag anymore, so this rule is unused. What's more, this unused rule will interfere with the look of any docs outputs themselves when these contain one or more `footer` tags nested inside of `blockquote` like http://html5doctor.com/cite-and-blockquote-reloaded/ suggests that one might one to do when quoting some other work. Specifically, you can see this happen in the docs for one of mine crates; * https://docs.rs/persistence/0.0.2/persistence/#what-this-library-is-and-what-it-is-not * https://github.com/ctsrc/persistence/blob/2375f30ae37ac5b8fa42af96cd35afd66a79bd76/src/lib.rs#L81-L96 Originally, I was planning on suggesting that the rule be limited to be more specific, but since I see that it goes unused, I suggest removing it all-together.
QuietMisdreavus
approved these changes
Sep 30, 2019
Contributor
QuietMisdreavus
left a comment
QuietMisdreavus
left a comment
There was a problem hiding this comment.
Nice catch, thanks so much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rules matching a
footertag were originally there for styling of a sponsor logo (as shown bygit blame) on crates.fyi.None of the templates output a
footertag anymore, so this rule is unused.What's more, this unused rule will interfere with the look of any docs outputs themselves when these contain one or more
footertags nested inside ofblockquotelike http://html5doctor.com/cite-and-blockquote-reloaded/ suggests that one might one to do when quoting some other work.Specifically, you can see this happen in the docs for one of mine crates;
Originally, I was planning on suggesting that the rule be limited to be more specific, but since I see that it goes unused, I suggest removing it all-together.