Skip to content

Conversation

@syphar
Copy link
Member

@syphar syphar commented Nov 17, 2025

A click too much created the PR, now I'll just leave it as WIP.

First step towards #1560.

I can't let go of the fact that Firefox is redownloading all that stuff from the CDN. After research, the next reason could be that we currently don't return ETags.

This PR implements this, first for:

  1. our own static files
  2. static resources returned from docs

Next steps after this then:

  • figure out how we could generate a ETag for rustdoc pages, without generating them. ( note to myself: does MatchedRelease contain enough information for this?)

remaining TODO:

  • research why Option<TypedHeader<IfNoneMatch>> never returns None, even when the header is missing

@syphar syphar requested a review from a team as a code owner November 17, 2025 05:53
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Nov 17, 2025
@syphar syphar self-assigned this Nov 17, 2025
@syphar syphar marked this pull request as draft November 17, 2025 05:54
@syphar syphar changed the title Etag static WIP: set etags for static resources Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant