-
Notifications
You must be signed in to change notification settings - Fork 102
Image cleanup #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Image cleanup #254
Conversation
fee7592
to
d13c961
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through the commits, everything looked reasonable. Left one question.
rm rustup-init; \ | ||
chmod -R a+w $RUSTUP_HOME $CARGO_HOME; \ | ||
\ | ||
apt-get purge -y --auto-remove -o APT::AutoRemove::RecommendsImportant=false; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Dockerfile-slim, you remove wget, here you remove.. everything? Or what does apt-get purge
without an argument do?
While looking at some of
docker-library
'sDockerfile
s, I realized that our currentDockerfile
format could be improved, and we should try to roughly match theirs. This PR is a collection of changes that hopefully make things better.References:
docker/28/cli/Dockerfile
gcc/15/Dockerfile
julia/1.11/trixie/Dockerfile
php/8.4/trixie/cli/Dockerfile
postgres/18/trixie/Dockerfile
pypy/3.11/trixie/Dockerfile
--progress=dot:giga
cc @Kobzol, @sfackler