Add regression test for #1205 #9943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth3lbert
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
The implemented regression test looks good.
I noticed that issue #1205 actually mentions two issues: owner removal and yanking.
The regression test for owner removal has been added. Should we also add a test for yanking?
This comment was marked as outdated.
This comment was marked as outdated.
This makes it easier to write non-flaky tests :)
initially I agreed, but I just checked the
I've rebased this PR on top of #9946 now to take advantage of the easier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to reproduce the failure describe in #1205, but it seems like something in between 2017 and now has already fixed the original issue. A regression test still seems useful though, which is what this PR is adding.
Resolves #1205
Related: