Skip to content

Remove BATCH_UPDATE_DOWNLOADS feature flag #8200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Remove BATCH_UPDATE_DOWNLOADS feature flag #8200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/config/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ pub struct Server {
pub cdn_log_counting_enabled: bool,
pub cdn_log_storage: CdnLogStorageConfig,
pub cdn_log_queue: CdnLogQueueConfig,
/// If `true`, the `update_downloads` background job will use batch
/// processing with a static SQL query.
pub batch_update_downloads: bool,
pub session_key: cookie::Key,
pub gh_client_id: ClientId,
pub gh_client_secret: ClientSecret,
Expand Down Expand Up @@ -189,7 +186,6 @@ impl Server {
cdn_log_counting_enabled: var("CDN_LOG_COUNTING_ENABLED")?.is_some(),
cdn_log_storage: CdnLogStorageConfig::from_env()?,
cdn_log_queue: CdnLogQueueConfig::from_env()?,
batch_update_downloads: var("BATCH_UPDATE_DOWNLOADS")?.is_some(),
base,
ip,
port,
Expand Down
1 change: 0 additions & 1 deletion src/tests/util/test_app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,6 @@ fn simple_config() -> config::Server {
cdn_log_counting_enabled: false,
cdn_log_queue: CdnLogQueueConfig::Mock,
cdn_log_storage: CdnLogStorageConfig::memory(),
batch_update_downloads: true,
session_key: cookie::Key::derive_from("test this has to be over 32 bytes long".as_bytes()),
gh_client_id: ClientId::new(dotenvy::var("GH_CLIENT_ID").unwrap_or_default()),
gh_client_secret: ClientSecret::new(dotenvy::var("GH_CLIENT_SECRET").unwrap_or_default()),
Expand Down
Loading