Revert "sentry: Enable tracing feature"
#3855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 43ac758. Using `tracing_subscriber::fmt::layer()` disabled the `RUST_LOG` based env filter. But if we add the filter to the registry it basically disables the breadcrumb tracing for Sentry. https://docs.rs/tracing-subscriber/0.2.20/tracing_subscriber/layer/trait.Layer.html#filtering-with-layers has more information on this. Until we find a way to filter what the `fmt` subscriber prints without disabling the breadcrumbs for Sentry we should probably not use their `tracing` integration.
Turbo87
added
C-internal 🔧
Member
|
@bors r+ |
Contributor
|
📌 Commit 26534c8 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 43ac758.
Using
tracing_subscriber::fmt::layer()disabled theRUST_LOGbased env filter. But if we add the filter to the registry it basically disables the breadcrumb tracing for Sentry. https://docs.rs/tracing-subscriber/0.2.20/tracing_subscriber/layer/trait.Layer.html#filtering-with-layers has more information on this. Until we find a way to filter what thefmtsubscriber prints without disabling the breadcrumbs for Sentry we should probably not use theirtracingintegration.