Add crate adapter that coalesces findRecord() requests
#3447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
A-frontend 🐹
C-internal 🔧
bors
added a commit
that referenced
this pull request
Apr 7, 2021
Load and show crate descriptions for dependency lists This PR adds the crate descriptions to the dependency and reverse dependency lists: <img width="1191" alt="Bildschirmfoto 2021-03-21 um 21 24 01" src="https://user-images.githubusercontent.com/141300/111919749-dbf0a300-8a8b-11eb-841f-5a9fef19d30f.png"> <img width="1156" alt="Bildschirmfoto 2021-03-21 um 21 23 30" src="https://user-images.githubusercontent.com/141300/111919753-e01cc080-8a8b-11eb-9fb1-a3465a3db6be.png"> <img width="1170" alt="Bildschirmfoto 2021-03-21 um 21 23 22" src="https://user-images.githubusercontent.com/141300/111919756-e0b55700-8a8b-11eb-9e1e-198042890d4a.png"> The descriptions (and other `crate` details) are loaded async, so I've added a description placeholder that is replaced once the request has returned. If the request fails the row is simply displayed without a description. The PR is based on #3447 to avoid unnecessary N+1 requests. Closes #2790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #3445 and #3426 and allows
findRecord('crate', ...)calls to be grouped into a single network request if they are started within the same runloop tick. This helps to prevent unintended N+1 request situations and enables us to implement #3405 in a more efficient way.