Improve invalid semver string handling #3304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jtgeibel (rust-highfive has picked a reviewer for you, use r? to override) |
|
looks great. could you check if it's possible to add a few tests for these cases? 🙏 |
plaets
force-pushed
the
issue-3294
branch
5 times, most recently
from
a0f3296 to
91c2072
Compare
|
I added some tests, but honestly, I'm not very familiar with ember so I'm not entirely happy with the results. If you have any comments, anything I should or should not test, please let me know.
And sorry for force-push spam, I forgot to remove/check some stuff before pushing. |
|
☔ The latest upstream changes (presumably #3263) made this pull request unmergeable. Please resolve the merge conflicts. |
…id/versions` * Add a tooltip message and a new icon to components/version-list/row * Handle null returned from `semverParse` in models/version * Add `loose` option to `semverParse` (https://github.com/npm/node-semver#functions)
* Add tests for version-list/row * Add tests for invalid/non-standard semver strings to models/version tests * Add loose option to more node-semver calls
Turbo87
changed the title
crates/:crate_id/versions
|
looks great, thanks! @bors r+ |
|
📌 Commit aebe476 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?) to components/version-list/rowsemverParsein models/versionlooseoption tosemverParse(https://github.com/npm/node-semver#functions)I placed the checks so that "invalid version" has higher priority than "first version" but lower than "yanked".
I also modified css of the version list so that long versions do not overflow from tooltips.
Before
After
Fixes #3294