Revert "Auto merge of #2001 - rust-lang:dependabot/npm_and_yarn/ember… #2027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @smarnach (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @Turbo87 |
|
cursed log line #666 from the rust tests: so that's fun |
|
🙈 |
bors
added a commit
that referenced
this pull request
Dec 20, 2019
routes/github-authorize: Fix `queryParams` code Accessing `queryParams` on the `transition` object was never officially public API in Ember.js, and has been deprecated in Ember.js v3.6 (see https://deprecations.emberjs.com/v3.x#toc_transition-state). Since it was only considered "intimate" API its removal was done in v3.9 instead of v4.0. Since we skipped both of these versions we unfortunately never saw the corresponding deprecation warning... 😞 But even if we did upgrade to v3.8 LTS in between, we probably still would have missed it, because the `github-authorize` route is only called in a popup window where the usual DevTools console is not attached, and we unfortunately don't have any test for the login flow (yet!). Closes #2027, Resolves #2028 @carols10cents r?
|
Closing in favor of #2029. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-source-3.15.0, r=Turbo87"
This reverts commit 97ecbf3, reversing
changes made to 6cfc3bf.
@Turbo87 I did manual testing of logging in because you mentioned you weren't able to test it; when I was on face1f3 logging in didn't work for me.
I did a git bisect and it pointed to the ember-source upgrade #2001 which is... all of ember? I'm not really sure how to go about debugging this further, but I'm going to try and I'll open a new issue with more details as I figure them out.
Reverting the ember-source upgrade lets me log in again, so this should make master deployable.
I really really wish we could have a full-stack automated test for logging in with GitHub, but I don't see that happening anytime soon!!