Skip to content

Migrate faker imports #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Migrate faker imports #1983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a30105c
Add `faker` dependency
Turbo87 Dec 18, 2019
ae3be09
Fix `faker` imports
Turbo87 Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mirage/factories/category.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Factory, faker } from 'ember-cli-mirage';
import { Factory } from 'ember-cli-mirage';
import faker from 'faker';
import { dasherize } from '@ember/string';

export default Factory.extend({
Expand Down
3 changes: 2 additions & 1 deletion mirage/factories/crate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Factory, trait, faker } from 'ember-cli-mirage';
import { Factory, trait } from 'ember-cli-mirage';
import faker from 'faker';

export default Factory.extend({
id(i) {
Expand Down
3 changes: 2 additions & 1 deletion mirage/factories/version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Factory, faker } from 'ember-cli-mirage';
import { Factory } from 'ember-cli-mirage';
import faker from 'faker';

export default Factory.extend({
id: i => i,
Expand Down
24 changes: 9 additions & 15 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
"eslint-config-prettier": "^6.7.0",
"eslint-plugin-ember": "^7.7.2",
"eslint-plugin-prettier": "^3.1.0",
"faker": "^4.1.0",
"loader.js": "^4.5.1",
"normalize.css": "^7.0.0",
"nyc": "^14.1.1",
Expand Down
2 changes: 1 addition & 1 deletion tests/helpers/setup-mirage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
import { faker } from 'ember-cli-mirage';
import faker from 'faker';
import timekeeper from 'timekeeper';

export default function(hooks) {
Expand Down