og_image: Use binary prefixes for format_bytes
#11531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, looking at the Wiki page again, I guess it should be |
|
I don't understand why the tests are failing in CI but passing on my machine. |
Turbo87
added
C-enhancement ✨
Technically `k` is correct, but for casing consistency with `KiB` we'll use uppercase now...
Might have been related to #11530 I've rebased it and CI seems to be happy now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of SI prefixes to denote powers of 1024 is incorrect:
This just changes them to use the proper
kiBandMiBinstead ofkBandMB.An alternative would be changing the code instead, to use powers of 1000 like
format_numberdoes, but that might be a bit ambiguous precisely because this error is still so common.