Skip to content

ember-data: Fix ember-data:deprecate-array-like warning #10173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/controllers/categories.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import Controller from '@ember/controller';
import { tracked } from '@glimmer/tracking';

import { reads } from 'macro-decorators';

import { pagination } from '../utils/pagination';

export default class CategoriesController extends Controller {
Expand All @@ -11,11 +9,13 @@ export default class CategoriesController extends Controller {
@tracked per_page = 100;
@tracked sort = 'alpha';

@reads('model.meta.total') totalItems;

@pagination() pagination;

get currentSortBy() {
return this.sort === 'crates' ? '# Crates' : 'Alphabetical';
}

get totalItems() {
return this.model.meta.total ?? 0;
}
}
8 changes: 4 additions & 4 deletions app/controllers/category/index.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import Controller from '@ember/controller';
import { tracked } from '@glimmer/tracking';

import { reads } from 'macro-decorators';

import { pagination } from '../../utils/pagination';

export default class CategoryIndexController extends Controller {
Expand All @@ -11,8 +9,6 @@ export default class CategoryIndexController extends Controller {
@tracked per_page = 10;
@tracked sort = 'recent-downloads';

@reads('model.meta.total') totalItems;

@pagination() pagination;

category = null;
Expand All @@ -30,4 +26,8 @@ export default class CategoryIndexController extends Controller {
return 'Recent Downloads';
}
}

get totalItems() {
return this.model.meta.total ?? 0;
}
}
8 changes: 4 additions & 4 deletions app/controllers/crate/reverse-dependencies.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import Controller from '@ember/controller';
import { tracked } from '@glimmer/tracking';

import { reads } from 'macro-decorators';

import { pagination } from '../../utils/pagination';

export default class ReverseDependenciesController extends Controller {
Expand All @@ -11,7 +9,9 @@ export default class ReverseDependenciesController extends Controller {
@tracked per_page = 10;
@tracked crate = null;

@reads('model.meta.total') totalItems;

@pagination() pagination;

get totalItems() {
return this.model.meta.total ?? 0;
}
}
7 changes: 4 additions & 3 deletions app/controllers/crates.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import Controller from '@ember/controller';
import { tracked } from '@glimmer/tracking';

import { reads } from 'macro-decorators';

import { pagination } from '../utils/pagination';

export default class CratesController extends Controller {
Expand All @@ -11,7 +9,6 @@ export default class CratesController extends Controller {
@tracked per_page = 50;
@tracked sort = 'recent-downloads';

@reads('model.meta.total') totalItems;
@pagination() pagination;

get currentSortBy() {
Expand All @@ -27,4 +24,8 @@ export default class CratesController extends Controller {
return 'Alphabetical';
}
}

get totalItems() {
return this.model.meta.total ?? 0;
}
}
8 changes: 4 additions & 4 deletions app/controllers/keyword.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import Controller from '@ember/controller';
import { tracked } from '@glimmer/tracking';

import { reads } from 'macro-decorators';

import { pagination } from '../utils/pagination';

export default class KeywordIndexController extends Controller {
Expand All @@ -11,8 +9,6 @@ export default class KeywordIndexController extends Controller {
@tracked per_page = 10;
@tracked sort = 'recent-downloads';

@reads('model.crates.meta.total') totalItems;

@pagination() pagination;

get currentSortBy() {
Expand All @@ -28,4 +24,8 @@ export default class KeywordIndexController extends Controller {
return 'Recent Downloads';
}
}

get totalItems() {
return this.model.crates.meta.total ?? 0;
}
}
8 changes: 4 additions & 4 deletions app/controllers/keywords.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import Controller from '@ember/controller';
import { tracked } from '@glimmer/tracking';

import { reads } from 'macro-decorators';

import { pagination } from '../utils/pagination';

export default class KeywordsController extends Controller {
Expand All @@ -11,11 +9,13 @@ export default class KeywordsController extends Controller {
@tracked per_page = 10;
@tracked sort = 'crates';

@reads('model.meta.total') totalItems;

@pagination() pagination;

get currentSortBy() {
return this.sort === 'crates' ? '# Crates' : 'Alphabetical';
}

get totalItems() {
return this.model.meta.total ?? 0;
}
}
8 changes: 4 additions & 4 deletions app/controllers/me/crates.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import Controller from '@ember/controller';
import { tracked } from '@glimmer/tracking';

import { reads } from 'macro-decorators';

import { pagination } from '../../utils/pagination';

// TODO: reduce duplicatoin with controllers/crates
Expand All @@ -13,8 +11,6 @@ export default class MeCratesController extends Controller {
@tracked per_page = 10;
@tracked sort = 'alpha';

@reads('model.meta.total') totalItems;

@pagination() pagination;

get currentSortBy() {
Expand All @@ -30,4 +26,8 @@ export default class MeCratesController extends Controller {
return 'Alphabetical';
}
}

get totalItems() {
return this.model.meta.total ?? 0;
}
}
8 changes: 4 additions & 4 deletions app/controllers/me/following.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import Controller from '@ember/controller';
import { tracked } from '@glimmer/tracking';

import { reads } from 'macro-decorators';

import { pagination } from '../../utils/pagination';

// TODO: reduce duplicatoin with controllers/me/crates
Expand All @@ -13,11 +11,13 @@ export default class FollowingController extends Controller {
@tracked per_page = 10;
@tracked sort = 'alpha';

@reads('model.meta.total') totalItems;

@pagination() pagination;

get currentSortBy() {
return this.sort === 'downloads' ? 'Downloads' : 'Alphabetical';
}

get totalItems() {
return this.model.meta.total ?? 0;
}
}
6 changes: 4 additions & 2 deletions app/controllers/search.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ export default class SearchController extends Controller {
return !this.dataTask.lastComplete && this.dataTask.isRunning;
}

@reads('model.meta.total') totalItems;

@pagination() pagination;

get pageTitle() {
Expand Down Expand Up @@ -75,4 +73,8 @@ export default class SearchController extends Controller {

return await this.store.query('crate', searchOptions);
});

get totalItems() {
return this.model.meta.total ?? 0;
}
}
8 changes: 4 additions & 4 deletions app/controllers/team.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import Controller from '@ember/controller';
import { tracked } from '@glimmer/tracking';

import { reads } from 'macro-decorators';

import { pagination } from '../utils/pagination';

export default class TeamController extends Controller {
Expand All @@ -11,8 +9,6 @@ export default class TeamController extends Controller {
@tracked per_page = 10;
@tracked sort = 'alpha';

@reads('model.crates.meta.total') totalItems;

@pagination() pagination;

get currentSortBy() {
Expand All @@ -28,4 +24,8 @@ export default class TeamController extends Controller {
return 'Alphabetical';
}
}

get totalItems() {
return this.model.crates.meta.total ?? 0;
}
}
8 changes: 4 additions & 4 deletions app/controllers/user.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import Controller from '@ember/controller';
import { tracked } from '@glimmer/tracking';

import { reads } from 'macro-decorators';

import { pagination } from '../utils/pagination';

// TODO: reduce duplication with controllers/crates
Expand All @@ -13,8 +11,6 @@ export default class UserController extends Controller {
@tracked per_page = 10;
@tracked sort = 'alpha';

@reads('model.crates.meta.total') totalItems;

@pagination() pagination;

get currentSortBy() {
Expand All @@ -30,4 +26,8 @@ export default class UserController extends Controller {
return 'Alphabetical';
}
}

get totalItems() {
return this.model.crates.meta.total ?? 0;
}
}
Loading