Skip to content

controllers/krate/publish: Add more tracing instrumentation #10090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 27, 2024

Just to get a bit more insight... the old split_body() fn was also instrumented but I forgot to add the attributes in #10069 when implementing the new fns.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 27, 2024
@Turbo87 Turbo87 enabled auto-merge (squash) November 27, 2024 20:11
@Turbo87 Turbo87 merged commit 99aed5b into rust-lang:main Nov 27, 2024
8 checks passed
@Turbo87 Turbo87 deleted the publish-instrumentation branch November 27, 2024 20:20
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.48%. Comparing base (1b5de48) to head (27cba4f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10090      +/-   ##
==========================================
- Coverage   89.48%   89.48%   -0.01%     
==========================================
  Files         295      295              
  Lines       31293    31265      -28     
==========================================
- Hits        28002    27976      -26     
+ Misses       3291     3289       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant