background_jobs: Remove unused AddCrate job

This has been replaced by the two `SyncToGit/SparseIndex` jobs

Author: Turbo87

src/background_jobs.rs

@@ -70,7 +70,6 @@ macro_rules! job_variant_from_value {
 
 jobs! {
     pub enum Job {
-        AddCrate(AddCrateJob),
         DailyDbMaintenance,
         DumpDb(DumpDbJob),
         NormalizeIndex(NormalizeIndexJob),
@@ -124,10 +123,6 @@ impl Job {
         Ok(())
     }
 
-    pub fn add_crate(krate: cargo_registry_index::Crate) -> Self {
-        Self::AddCrate(AddCrateJob { krate })
-    }
-
     pub fn daily_db_maintenance() -> Self {
         Self::DailyDbMaintenance
     }
@@ -208,7 +203,6 @@ impl Job {
                 worker::perform_daily_db_maintenance(&mut *fresh_connection(pool)?)
             }
             Job::DumpDb(args) => worker::perform_dump_db(env, args.database_url, args.target_name),
-            Job::AddCrate(args) => worker::perform_index_add_crate(env, conn, &args.krate),
             Job::SquashIndex => worker::perform_index_squash(env),
             Job::UpdateCrateIndex(args) => worker::perform_index_sync_to_http(env, args.crate_name),
             Job::NormalizeIndex(args) => worker::perform_normalize_index(env, args),

src/worker/git.rs

@@ -1,41 +1,14 @@
-use crate::background_jobs::{Environment, Job, NormalizeIndexJob};
+use crate::background_jobs::{Environment, NormalizeIndexJob};
 use crate::models;
 use crate::swirl::PerformError;
 use anyhow::Context;
 use cargo_registry_index::{Crate, Repository};
 use chrono::Utc;
 use diesel::prelude::*;
-use std::fs::{self, File, OpenOptions};
+use std::fs::{self, File};
 use std::io::{BufRead, BufReader, ErrorKind, Write};
 use std::process::Command;
 
-#[instrument(skip_all, fields(krate.name = ?krate.name, krate.vers = ?krate.vers))]
-pub fn perform_index_add_crate(
-    env: &Environment,
-    conn: &mut PgConnection,
-    krate: &Crate,
-) -> Result<(), PerformError> {
-    info!("Adding {}#{} to the git index", krate.name, krate.vers);
-
-    use std::io::prelude::*;
-
-    let repo = env.lock_index()?;
-    let dst = repo.index_file(&krate.name);
-
-    // Add the crate to its relevant file
-    fs::create_dir_all(dst.parent().unwrap())?;
-    let mut file = OpenOptions::new().append(true).create(true).open(&dst)?;
-    serde_json::to_writer(&mut file, &krate)?;
-    file.write_all(b"\n")?;
-
-    let message: String = format!("Update crate `{}#{}`", krate.name, krate.vers);
-    repo.commit_and_push(&message, &dst)?;
-
-    // Queue another background job to update the http-based index as well.
-    Job::update_crate_index(krate.name.clone()).enqueue(conn)?;
-    Ok(())
-}
-
 #[instrument(skip(env))]
 pub fn perform_index_sync_to_http(
     env: &Environment,

src/worker/mod.rs

@@ -13,8 +13,8 @@ mod update_downloads;
 pub(crate) use daily_db_maintenance::perform_daily_db_maintenance;
 pub(crate) use dump_db::perform_dump_db;
 pub(crate) use git::{
-    perform_index_add_crate, perform_index_squash, perform_index_sync_to_http,
-    perform_normalize_index, sync_to_git_index, sync_to_sparse_index,
+    perform_index_squash, perform_index_sync_to_http, perform_normalize_index, sync_to_git_index,
+    sync_to_sparse_index,
 };
 pub(crate) use readmes::perform_render_and_upload_readme;
 pub(crate) use update_downloads::perform_update_downloads;