background_jobs: Remove unused SyncYanked job

This has been replaced by the two `SyncToGit/SparseIndex` jobs

Author: Turbo87

src/background_jobs.rs

@@ -78,7 +78,6 @@ jobs! {
         SquashIndex,
         SyncToGitIndex(SyncToIndexJob),
         SyncToSparseIndex(SyncToIndexJob),
-        SyncYanked(SyncYankedJob),
         UpdateCrateIndex(UpdateCrateIndexJob),
         UpdateDownloads,
     }
@@ -176,10 +175,6 @@ impl Job {
         })
     }
 
-    pub fn sync_yanked(krate: String, version_num: String) -> Self {
-        Self::SyncYanked(SyncYankedJob { krate, version_num })
-    }
-
     pub fn update_crate_index(crate_name: String) -> Self {
         Self::UpdateCrateIndex(UpdateCrateIndexJob { crate_name })
     }
@@ -216,9 +211,6 @@ impl Job {
             Job::AddCrate(args) => worker::perform_index_add_crate(env, conn, &args.krate),
             Job::SquashIndex => worker::perform_index_squash(env),
             Job::UpdateCrateIndex(args) => worker::perform_index_sync_to_http(env, args.crate_name),
-            Job::SyncYanked(args) => {
-                worker::perform_index_update_yanked(env, conn, &args.krate, &args.version_num)
-            }
             Job::NormalizeIndex(args) => worker::perform_normalize_index(env, args),
             Job::RenderAndUploadReadme(args) => worker::perform_render_and_upload_readme(
                 conn,

src/worker/git.rs

@@ -1,6 +1,5 @@
 use crate::background_jobs::{Environment, Job, NormalizeIndexJob};
 use crate::models;
-use crate::schema;
 use crate::swirl::PerformError;
 use anyhow::Context;
 use cargo_registry_index::{Crate, Repository};
@@ -157,66 +156,6 @@ pub fn get_index_data(name: &str, conn: &mut PgConnection) -> anyhow::Result<Opt
     Ok(Some(str))
 }
 
-/// Yanks or unyanks a crate version. This requires finding the index
-/// file, deserlialise the crate from JSON, change the yank boolean to
-/// `true` or `false`, write all the lines back out, and commit and
-/// push the changes.
-#[instrument(skip(env, conn))]
-pub fn perform_index_update_yanked(
-    env: &Environment,
-    conn: &mut PgConnection,
-    krate: &str,
-    version_num: &str,
-) -> Result<(), PerformError> {
-    info!("Syncing yanked status from database into the index");
-
-    debug!("Loading yanked status from database");
-
-    let yanked: bool = schema::versions::table
-        .inner_join(schema::crates::table)
-        .filter(schema::crates::name.eq(&krate))
-        .filter(schema::versions::num.eq(&version_num))
-        .select(schema::versions::yanked)
-        .get_result(conn)
-        .context("Failed to load yanked status from database")?;
-
-    debug!(yanked);
-
-    let repo = env.lock_index()?;
-    let dst = repo.index_file(krate);
-
-    let prev = fs::read_to_string(&dst)?;
-    let new = prev
-        .lines()
-        .map(|line| {
-            let mut git_crate = serde_json::from_str::<Crate>(line)
-                .map_err(|_| format!("couldn't decode: `{line}`"))?;
-            if git_crate.name != krate || git_crate.vers != version_num {
-                return Ok(line.to_string());
-            }
-            git_crate.yanked = Some(yanked);
-            Ok(serde_json::to_string(&git_crate)?)
-        })
-        .collect::<Result<Vec<_>, PerformError>>();
-    let new = new?.join("\n") + "\n";
-
-    if new != prev {
-        fs::write(&dst, new.as_bytes())?;
-
-        let action = if yanked { "Yank" } else { "Unyank" };
-        let message = format!("{action} crate `{krate}#{version_num}`");
-
-        repo.commit_and_push(&message, &dst)?;
-    } else {
-        debug!("Skipping `yanked` update because index is up-to-date");
-    }
-
-    // Queue another background job to update the http-based index as well.
-    Job::update_crate_index(krate.to_string()).enqueue(conn)?;
-
-    Ok(())
-}
-
 /// Collapse the index into a single commit, archiving the current history in a snapshot branch.
 #[instrument(skip(env))]
 pub fn perform_index_squash(env: &Environment) -> Result<(), PerformError> {

src/worker/mod.rs

@@ -14,7 +14,7 @@ pub(crate) use daily_db_maintenance::perform_daily_db_maintenance;
 pub(crate) use dump_db::perform_dump_db;
 pub(crate) use git::{
     perform_index_add_crate, perform_index_squash, perform_index_sync_to_http,
-    perform_index_update_yanked, perform_normalize_index, sync_to_git_index, sync_to_sparse_index,
+    perform_normalize_index, sync_to_git_index, sync_to_sparse_index,
 };
 pub(crate) use readmes::perform_render_and_upload_readme;
 pub(crate) use update_downloads::perform_update_downloads;