Bump libgit2-sys version to be compatible with systems that have newer libgit2 #598
Conversation
libgit2-sys builds a vendored libgit2 if the system version is too old, but not if it is too new. So at the moment we need to keep this updated or we end up linked against an incompatible version on systems that upgrade system packages aggressively.
saethlin
force-pushed
the
vendored-libgit
branch
from
975fe21 to
3cafbf2
Compare
saethlin
changed the title
|
Can you say whether this is a problem if the system is old? (Including quite old -- some of our servers with Crater running on them are on pretty old LTS distributions these days). |
|
This PR bumps the required libgit2 version from 1.1.0 to 1.3.0. The libgit2-sys crate compiles a vendored libgit2 version is if the system version is too old. So as far as I can tell, on any LTS Ubuntu, the distro version of libgit2 was already too old (they only ship 0.28 at best). So those servers should already be building a vendored libgit2, this patch would just change the version that the builds are vendoring. |
|
@bors r+ |
|
📌 Commit 3cafbf2 has been approved by |
|
☀️ Test successful - checks-actions |
cargo run -- prepare-localdoesn't work at the moment on Arch/Manjaro, because rolling release distros are shippinglibgit1.3.0, which has a compatability break (intentional or not it's unclear) since 1.1.0.libgit2-syswill build a vendored version if the system version is too old, but not if it is too new. So with this change, the build should be correct on all systems.I'm running into the same error as rustsec/rustsec#431 and applying the fix suggested therein.