Rustdoc nocapture #9705
Closed
Rustdoc nocapture #9705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Eh2406 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
rustdoc-nocapture
branch
3 times, most recently
from
12e27f3 to
287987e
Compare
tristan957
reviewed
Jul 20, 2021
GuillaumeGomez
force-pushed
the
rustdoc-nocapture
branch
from
287987e to
0b39bb9
Compare
ehuss
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #10408) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing as this is a bit stale. I'm also not clear what this was needed, since it looks like one can just pass |
|
The current cargo doesn't work, I assume because |
|
Is this fixed? |
|
Doesn't seem like.. but in the interim, try this: |
|
@ehuss @GuillaumeGomez Can you please consider reopening this? It seems the hard work has already been done in rustdoc, and but given most people use rustdoc via cargo, it's availability is quite hindered. Or am I misinterpreting the state of |
|
I can't reopen it so I'll let it up to cargo team. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 29, 2025
…ddle rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest` Context: rust-lang#133073, rust-lang#139224 (TL;DR: `libtest` has soft-deprecated `--nocapture` in favor a new & stable `--no-capture`; we should follow suit). Since the rustdoc flag is unstable (tracking issue: rust-lang#148116), we're allowed to remove the old flag immediately. However since the flag has existed for 4 years we could hard-deprecate the flag first or at least be considerate and provide a diagnostic referring users to the new flag. This PR does neither. Let me know what you would think would be best. Cargo doesn't use this flag, not yet at least (rust-lang/cargo#9705), so we really are free to sunset this flag without bigger consequences.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 30, 2025
…ddle rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest` Context: rust-lang#133073, rust-lang#139224 (TL;DR: `libtest` has soft-deprecated `--nocapture` in favor a new & stable `--no-capture`; we should follow suit). Since the rustdoc flag is unstable (tracking issue: rust-lang#148116), we're allowed to remove the old flag immediately. However since the flag has existed for 4 years we could hard-deprecate the flag first or at least be considerate and provide a diagnostic referring users to the new flag. This PR does neither. Let me know what you would think would be best. Cargo doesn't use this flag, not yet at least (rust-lang/cargo#9705), so we really are free to sunset this flag without bigger consequences.
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Oct 30, 2025
…ddle rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest` Context: rust-lang#133073, rust-lang#139224 (TL;DR: `libtest` has soft-deprecated `--nocapture` in favor a new & stable `--no-capture`; we should follow suit). Since the rustdoc flag is unstable (tracking issue: rust-lang#148116), we're allowed to remove the old flag immediately. However since the flag has existed for 4 years we could hard-deprecate the flag first or at least be considerate and provide a diagnostic referring users to the new flag. This PR does neither. Let me know what you would think would be best. Cargo doesn't use this flag, not yet at least (rust-lang/cargo#9705), so we really are free to sunset this flag without bigger consequences.
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Oct 30, 2025
Rollup merge of #148115 - fmease:rustdoc-no-capture, r=notriddle rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest` Context: #133073, #139224 (TL;DR: `libtest` has soft-deprecated `--nocapture` in favor a new & stable `--no-capture`; we should follow suit). Since the rustdoc flag is unstable (tracking issue: #148116), we're allowed to remove the old flag immediately. However since the flag has existed for 4 years we could hard-deprecate the flag first or at least be considerate and provide a diagnostic referring users to the new flag. This PR does neither. Let me know what you would think would be best. Cargo doesn't use this flag, not yet at least (rust-lang/cargo#9705), so we really are free to sunset this flag without bigger consequences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following rust-lang/rust#86230.
It might need to wait for rustdoc latest nightly to be published first to pass CI though (so tomorrow).
Also: the
--nocaptureoption is unstable for now in rustdoc, is there something particular to be done until it's stable on cargo side? For now I simply add-Zunstable-optionsbut not sure if it's the way to go?