Skip to content

Conversation

@jakobhellermann
Copy link
Contributor

What does this PR try to resolve?

Fish shell automatically wraps the help text in parenthesis, so this wil result in them being applied twice.

image

On zsh it previously looked like this

--target-dir                          -- Directory for all generated artifacts
--timings                             -- Timing output formats (unstable) (comma separated): html, json
--unit-graph                          -- Output build graph in JSON (unstable)
--verbose                             -- Use verbose output (-vv very verbose/build.rs output)
-Z                                    -- Unstable (nightly-only) flags to Cargo, see 'cargo -Z help' for details
fix-json                              -- (from rustfix)
matches                               -- (from cargo-platform)
stdout-redirected      file-provider  -- (from cargo-credential)

and will now be

fix-json                              -- from rustfix
matches                               -- from cargo-platform
stdout-redirected      file-provider  -- from cargo-credential

Bash doesn't show the help text at all so it doesn't matter.

Fish shell automatically wraps the help text in parenthesis, so this wil
result in them being applied twice.
@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2025

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jakobhellermann
Copy link
Contributor Author

(the fact that all the other flags are being completed at all in the middle of a flag accepting a value is due to the fact that we do optional arguments as .num_args(0..=1) where the 0 case is handled manually. I'll open another issue for that)

@epage epage added this pull request to the merge queue Nov 6, 2025
@epage
Copy link
Contributor

epage commented Nov 6, 2025

(the fact that all the other flags are being completed at all in the middle of a flag accepting a value is due to the fact that we do optional arguments as .num_args(0..=1) where the 0 case is handled manually. I'll open another issue for that)

See #14606

Merged via the queue into rust-lang:master with commit 88411f4 Nov 6, 2025
25 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2025
@jakobhellermann jakobhellermann deleted the completion-dont-wrap-paren branch November 6, 2025 14:52
bors added a commit to rust-lang/rust that referenced this pull request Nov 8, 2025
Update cargo submodule

22 commits in 6368002885a04cbeae39a82cf5118f941559a40a..445fe4a68f469bf936b2fd81de2c503b233a7f4f
2025-10-31 14:31:52 +0000 to 2025-11-07 18:08:19 +0000
- fix(depinfo): prevent invalid trailing backslash on Windows (rust-lang/cargo#16223)
- refactor: Remove lazycell (rust-lang/cargo#16224)
- refactor: extract ConfigValue to its own module (rust-lang/cargo#16222)
- fix(config): non-mergeable list from cli should take priority (rust-lang/cargo#16220)
- fix(compile): build.warnings=deny shouldn't block hard warnings (rust-lang/cargo#16213)
- fix: display absolute path in the `missing in PATH` warning (rust-lang/cargo#16125)
- fix: non-mergeable list from config cli merge the same way  (rust-lang/cargo#16219)
- docs(contrib): Link out to rustc diagnostic style guide (rust-lang/cargo#16216)
- fix: Remove build-plan (rust-lang/cargo#16212)
- Add native completions for `--package` on various commands (rust-lang/cargo#16210)
- fix(completions): don't wrap completion item help in parenthesis (rust-lang/cargo#16215)
- refactor(locking): Make disabling locking on NFS mounts explicit (rust-lang/cargo#16177)
- docs(unstable): Move compile-time-deps out of Stabilized section (rust-lang/cargo#16211)
- docs(ref): Rename DEP_NAME_KEY to DEP_LINKS_KEY (rust-lang/cargo#16205)
- feat(build-analysis): emit rebuild reason log entry (rust-lang/cargo#16203)
- chore: Update dependencies (rust-lang/cargo#16200)
- chore(deps): update cargo-semver-checks to v0.45.0 (rust-lang/cargo#16190)
- chore(deps): update msrv (rust-lang/cargo#16178)
- refactor: embed deserialize validation logic in ProgressConfig (rust-lang/cargo#16194)
- refactor(gctx): extract config schema to a module (rust-lang/cargo#16195)
- chore: bump to 0.94.0; update changelog (rust-lang/cargo#16191)
- chore(deps): update rust crate gix to 0.74.0 (rust-lang/cargo#16186)

r? ghost
@rustbot rustbot added this to the 1.93.0 milestone Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area: Command-line interface, option parsing, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants