Skip to content

Conversation

@ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 30, 2025

This fixes a mistake where the <a> tag was closed in the wrong spot causing the links to not be functional. It was intended that you can click on the option in order to get a link reference to the option, just like you can do with headers.

ehuss added 2 commits October 29, 2025 21:10
This fixes a mistake where the `<a>` tag was closed in the wrong spot
causing the links to not be functional. It was intended that you can
click on the option in order to get a link reference to the option, just
like you can do with headers.
This rebuilds the man pages with the correct `</a>` tag placement for
options.

This also includes some CSS to keep the same color as before.
@rustbot rustbot added A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2025

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I only looked at the rendering part but didn't hover and click them. Nice catch.

View changes since this review

@weihanglo weihanglo added this pull request to the merge queue Oct 30, 2025
Merged via the queue into rust-lang:master with commit 0540bde Oct 30, 2025
25 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 30, 2025
bors added a commit to rust-lang/rust that referenced this pull request Nov 1, 2025
Update cargo submodule

6 commits in 6c1b6100343691341b9e76c5acc594e78220f963..6368002885a04cbeae39a82cf5118f941559a40a
2025-10-28 16:27:52 +0000 to 2025-10-31 14:31:52 +0000
- feat(build-analysis): emit timing-info log (rust-lang/cargo#16179)
- Remove libc pin message (rust-lang/cargo#16182)
- feat(config-include): add optional field support (rust-lang/cargo#16180)
- feat(config-include): support inline and array of tables  (rust-lang/cargo#16174)
- test(script): Update from rustc's test suite (rust-lang/cargo#16169)
- Fix links for options in man pages (rust-lang/cargo#16172)

r? ghost
bors added a commit to rust-lang/rust that referenced this pull request Nov 1, 2025
Update cargo submodule

6 commits in 6c1b6100343691341b9e76c5acc594e78220f963..6368002885a04cbeae39a82cf5118f941559a40a
2025-10-28 16:27:52 +0000 to 2025-10-31 14:31:52 +0000
- feat(build-analysis): emit timing-info log (rust-lang/cargo#16179)
- Remove libc pin message (rust-lang/cargo#16182)
- feat(config-include): add optional field support (rust-lang/cargo#16180)
- feat(config-include): support inline and array of tables  (rust-lang/cargo#16174)
- test(script): Update from rustc's test suite (rust-lang/cargo#16169)
- Fix links for options in man pages (rust-lang/cargo#16172)

r? ghost
@rustbot rustbot added this to the 1.93.0 milestone Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants