Skip to content

Make "C" explicit in extern "C". #15034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Make "C" explicit in extern "C". #15034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/testsuite/build_script.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2255,7 +2255,7 @@ fn build_script_with_dynamic_native_dependency() {
crate-type = ["dylib"]
"#,
)
.file("src/lib.rs", "#[no_mangle] pub extern fn foo() {}")
.file("src/lib.rs", r#"#[no_mangle] pub extern "C" fn foo() {}"#)
.build();

let foo = project()
Expand Down Expand Up @@ -2316,7 +2316,7 @@ fn build_script_with_dynamic_native_dependency() {
pub fn bar() {
#[cfg_attr(not(target_env = "msvc"), link(name = "builder"))]
#[cfg_attr(target_env = "msvc", link(name = "builder.dll"))]
extern { fn foo(); }
extern "C" { fn foo(); }
unsafe { foo() }
}
"#,
Expand Down Expand Up @@ -4821,7 +4821,7 @@ fn _rename_with_link_search_path(cross: bool, expected: impl IntoData) {
)
.file(
"src/lib.rs",
"#[no_mangle] pub extern fn cargo_test_foo() {}",
r#"#[no_mangle] pub extern "C" fn cargo_test_foo() {}"#,
);
let p = p.build();

Expand Down Expand Up @@ -4866,7 +4866,7 @@ fn _rename_with_link_search_path(cross: bool, expected: impl IntoData) {
.file(
"src/main.rs",
r#"
extern {
extern "C" {
#[link_name = "cargo_test_foo"]
fn foo();
}
Expand Down
Loading