[beta] Remove strip = "off" (and undocumented strip = "n"/strip = "no")
#10377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…= "no"`) The `strip` option allows the string `"off"`, which `rustc` doesn't have, and maps it to `"none"`. Remove that equivalent, and just keep `"none"`. Simplify and clarify the documentation for `strip` accordingly. `strip` reused the `is_off` function from `lto`, which also had the net effect of allowing `"n"` and `"no"`, which weren't documented as supported. This change drops those as well.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
|
Thanks! @bors r+ |
|
📌 Commit bff8668 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
ehuss
added a commit
to ehuss/rust
that referenced
this pull request
Feb 10, 2022
Update includes: * rust-lang/cargo#10377
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 11, 2022
[beta] Backports Backports of: * rust-lang#92611 — Add links to the reference and rust by example for asm! docs and lints * rust-lang#92983 — Update Linux runners to Ubuntu 20.04 * rust-lang#93081 — Update LLVM submodule * rust-lang#93394 — Don't allow {} to refer to implicit captures in format_args. * Cargo: * rust-lang/cargo#10377 — Remove strip = "off" (and undocumented strip = "n"/strip = "no")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta backport of #10376
The
stripoption allows the string"off", whichrustcdoesn'thave, and maps it to
"none". Remove that equivalent, and just keep"none".Simplify and clarify the documentation for
stripaccordingly.stripreused theis_offfunction fromlto, which also had the neteffect of allowing
"n"and"no", which weren't documented assupported. This change drops those as well.