Skip to content

Help page redesign #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 16, 2025
Merged

Help page redesign #312

merged 14 commits into from
Jun 16, 2025

Conversation

Sakib25800
Copy link
Contributor

Redesigns the help page and adds some base styling.

  • Fira Sans is used since other Rust sites use it
  • Fira Mono for code blocks
  • #28607F is official Rust blue

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, I had no idea we even have such design constraints 😆 Where did you find out about the blue? :D

Could you please make the content max width be a bit wider? It's quite narrow on my FullHD monitor, kind of unnecessarily. Otherwise the page looks beautiful.

@Sakib25800
Copy link
Contributor Author

  • Rust Blue
  • Increased width from 50rem -> 80rem.

Technically that's the Rust Foundation brand colors, but it's official enough for me.

@Sakib25800 Sakib25800 force-pushed the help-page-redesign branch from 97396f3 to 4595b4b Compare June 13, 2025 15:37
@Kobzol
Copy link
Member

Kobzol commented Jun 13, 2025

Thanks! I went through the commands on the help page and noticed that it doesn't fully correspond to the help command (e.g. delegate=try is missing). Could you please double check it and make sure that everything that is in @bors help is on the help page? Thanks!

@Sakib25800
Copy link
Contributor Author

I've made sure that the help command and help page now match and also added rollup and rollup- to the help command as it was missing.

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Reading the help table in HTML is quite difficult, eventually we should define the help commands in Rust (even with just a tuple of (cmd, permissions, description) and then just render it in the template with a for loop, to avoid repeating all the HTML table items. But that doesn't need to happen here.

@Kobzol Kobzol added this pull request to the merge queue Jun 16, 2025
Merged via the queue into rust-lang:main with commit 77ecf60 Jun 16, 2025
2 checks passed
@Kobzol Kobzol mentioned this pull request Jun 20, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants