Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Aug 15, 2019

also fixes some minor inconsistencies

Closes #369

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Copy link

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nikomatsakis
Copy link
Contributor

r? @skade -- can you reassign this to someone from the web site working group who is more qualified to judge it? Thanks!

(Seems good to me, fwiw)

@nikomatsakis
Copy link
Contributor

Also, sorry for the delay in responding to the PR @BO41

@skade
Copy link
Contributor

skade commented Aug 26, 2019

@nikomatsakis oddly, website group doesn't have access here ;)

@skade
Copy link
Contributor

skade commented Aug 26, 2019

r+ from my side

@nikomatsakis
Copy link
Contributor

@bors r+

@nikomatsakis
Copy link
Contributor

Or I guess bors doesn't govern this, does it?

@pietroalbini pietroalbini merged commit 609b256 into rust-lang:master Aug 26, 2019
@styfle
Copy link

styfle commented Aug 26, 2019

Thanks!

@ghost ghost deleted the prefix branch August 26, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the $ prefix from all bash snippets

5 participants