Skip to content

feat: ExactSizeIterator impl for Chunks #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Huterenok
Copy link

@Huterenok Huterenok commented Jul 1, 2025

ExactSizeIterator impl Chunks and IntoChunks::len method. Also added #[must_use] for Chunk

Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.19%. Comparing base (6814180) to head (c09eac8).
Report is 149 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
- Coverage   94.38%   94.19%   -0.20%     
==========================================
  Files          48       50       +2     
  Lines        6665     6254     -411     
==========================================
- Hits         6291     5891     -400     
+ Misses        374      363      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Huterenok
Copy link
Author

CI failes with 3 issues:

  • semver-checks complains about moved CombinationsWithReplacement but these changes don't relate to my PR
  • semver-checks fails on minor check about new #[must_use] on Chunk. Should i remove this change from PR?
  • clippy complains about not used size_hint::div_ceil_scalar but it's definitely used in groupbylazy.rs and locally it doesn't complain. What's the deal?

@Huterenok Huterenok changed the title feat: ExactSizeIterator impl for IntoChunks feat: ExactSizeIterator impl for Chunks Jul 3, 2025
@Huterenok Huterenok closed this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant