Also always inline set_bit/clear bit

[therealprof]

Reduces build size by quite a bit in dev builds but to my surprise also
helps in optimised builds using set_bit/clear_bit indirectly via HAL
impls.

Closes #334

Signed-off-by: Daniel Egger [email protected]

[rust-highfive]

r? @ryankurte

(rust_highfive has picked a reviewer for you, use r? to override)

[therealprof]

e.g:

Bloat for example i2c_hal_ina260serial
Compiling ...
Analyzing target/thumbv6m-none-eabi/release/examples/i2c_hal_ina260serial

File  .text   Size          Crate Name
0.6%  72.9% 1.6KiB      [Unknown] main
0.1%   7.5%   168B stm32f042_hal? <stm32f042_hal::i2c::I2c<stm32f042::I2C1,PINS> as embedded_hal::blocking::i2c::WriteRead>::write_read
0.0%   5.8%   130B      [Unknown] __aeabi_uidiv
0.0%   3.4%    76B      [Unknown] __clzsi2
0.0%   2.9%    64B         ina260 ina260::INA260<I2C>::voltage
0.0%   2.9%    64B    cortex_m_rt Reset
0.0%   1.6%    36B  stm32f042_hal stm32f042_hal::i2c::I2c<stm32f042::I2C1,PINS>::send_byte
0.0%   1.4%    32B stm32f042_hal? <stm32f042_hal::serial::Tx<USART> as core::fmt::Write>::write_str
0.0%   0.3%     6B            std core::result::unwrap_failed
0.0%   0.3%     6B            std core::slice::slice_index_order_fail
0.0%   0.3%     6B            std core::panicking::panic_fmt
0.0%   0.3%     6B            std core::panicking::panic_bounds_check
0.0%   0.3%     6B            std core::slice::slice_index_len_fail
0.0%   0.1%     2B    cortex_m_rt HardFault_
0.0%   0.1%     2B    cortex_m_rt DefaultPreInit
0.0%   0.1%     2B    cortex_m_rt DefaultHandler_
0.0%   0.1%     2B     panic_halt rust_begin_unwind
0.0%   0.0%     0B                And 0 smaller methods. Use -n N to show more.
0.8% 100.0% 2.2KiB                .text section size, the file size is 258.6KiB

vs

Bloat for example i2c_hal_ina260serial
Compiling ...
Analyzing target/thumbv6m-none-eabi/release/examples/i2c_hal_ina260serial

File  .text   Size          Crate Name
0.6%  74.3% 1.6KiB      [Unknown] main
0.1%   7.3%   160B stm32f042_hal? <stm32f042_hal::i2c::I2c<stm32f042::I2C1,PINS> as embedded_hal::blocking::i2c::WriteRead>::write_read
0.0%   5.9%   130B      [Unknown] __aeabi_uidiv
0.0%   3.5%    76B      [Unknown] __clzsi2
0.0%   2.9%    64B         ina260 ina260::INA260<I2C>::voltage
0.0%   2.9%    64B    cortex_m_rt Reset
0.0%   1.5%    32B stm32f042_hal? <stm32f042_hal::serial::Tx<USART> as core::fmt::Write>::write_str
0.0%   0.3%     6B            std core::result::unwrap_failed
0.0%   0.3%     6B            std core::slice::slice_index_order_fail
0.0%   0.3%     6B            std core::panicking::panic_fmt
0.0%   0.3%     6B            std core::panicking::panic_bounds_check
0.0%   0.3%     6B            std core::slice::slice_index_len_fail
0.0%   0.1%     2B    cortex_m_rt HardFault_
0.0%   0.1%     2B    cortex_m_rt DefaultPreInit
0.0%   0.1%     2B    cortex_m_rt DefaultHandler_
0.0%   0.1%     2B     panic_halt rust_begin_unwind
0.0%   0.0%     0B                And 0 smaller methods. Use -n N to show more.
0.8% 100.0% 2.1KiB                .text section size, the file size is 257.4KiB

[therealprof]

CC @adamgreig

[Disasm]

LGTM!

[Disasm]

bors r+

[bors]

Build succeeded

• continuous-integration/travis-ci/push