Svd clusters #149
Closed
Svd clusters #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonedens
force-pushed
the
svd_clusters
branch
from
f02aff0 to
5ed5808
Compare
Cluster tags result in a struct definition that contains each of the children of that cluster. The children within a module of a type named after the cluster.
|
@brandonedens are you still working on this? |
|
ping @brandonedens |
Emilgardis
added a commit
to Emilgardis/stm32f103xx
that referenced
this pull request
Jan 29, 2018
I would preferably use a cluster here, but svd2rust doesn't yet have that feature. See rust-embedded/svd2rust#149 and rust-embedded/svd2rust#107 closes japaric#16
|
@Emilgardis I am working on fixing the merge conflicts for this. I will open it up as a separate PR when it is ready (hopefully soon). |
|
WIP here: https://github.com/jamesmunns/svd2rust/tree/james-cluster - merge is probably 80ish% done, still need to clean up a couple things. |
bors bot
added a commit
that referenced
this pull request
Mar 4, 2018
182: Add initial Cluster support r=jamesmunns a=jamesmunns Add cluster support to svd2rust. I am calling it initial, because I have only tested it against the `nRF52` [svd file](https://github.com/jamesmunns/nrf52/blob/master/nrf52.svd). Note, this is based on #180, so I would prefer that PR be merged first. If that PR is rejected, I can instead rebase these changes on `japaric/master` (just let me know). Edit: All changes relevant to clusters are squashed into the last commit of this PR, so if you want to see the relevant changes, check out 6de6de7. This is based on the work of @brandonedens earlier #149, and I believe would close #107 and related issues. CC @japaric @Emilgardis @therealprof Edit 2: Here are some handy references: * [SVD snippet with clusters](https://gist.github.com/jamesmunns/c4e53fe5bd74dca81fdbff6bb1798ddd) * [code generated before](https://gist.github.com/jamesmunns/d854a6c2665cca59edb88143d82a19c6) * [code generated after](https://gist.github.com/jamesmunns/7558667e34c33124c60b3aaaf679a196) * [diff of code generated](https://gist.github.com/jamesmunns/03fd0d7d3595cd0816dbfa8daca0a553)
|
Closed in favor of @jamesmunns work. |
bors bot
added a commit
that referenced
this pull request
Mar 8, 2018
182: Add initial Cluster support r=jamesmunns a=jamesmunns Add cluster support to svd2rust. I am calling it initial, because I have only tested it against the `nRF52` [svd file](https://github.com/jamesmunns/nrf52/blob/master/nrf52.svd). Note, this is based on #180, so I would prefer that PR be merged first. If that PR is rejected, I can instead rebase these changes on `japaric/master` (just let me know). Edit: All changes relevant to clusters are squashed into the last commit of this PR, so if you want to see the relevant changes, check out 6de6de7. This is based on the work of @brandonedens earlier #149, and I believe would close #107 and related issues. CC @japaric @Emilgardis @therealprof Edit 2: Here are some handy references: * [SVD snippet with clusters](https://gist.github.com/jamesmunns/c4e53fe5bd74dca81fdbff6bb1798ddd) * [code generated before](https://gist.github.com/jamesmunns/d854a6c2665cca59edb88143d82a19c6) * [code generated after](https://gist.github.com/jamesmunns/7558667e34c33124c60b3aaaf679a196) * [diff of code generated](https://gist.github.com/jamesmunns/03fd0d7d3595cd0816dbfa8daca0a553)
bors bot
added a commit
to japaric/stm32f103xx
that referenced
this pull request
Mar 10, 2018
19: Make EPnR into an array. r=japaric a=Emilgardis I would preferably use a cluster here, but svd2rust doesn't yet have that feature. See rust-embedded/svd2rust#149 and rust-embedded/svd2rust#107 closes #16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for generating rust software to support the tag.