Skip to content
This repository was archived by the owner on Jul 1, 2025. It is now read-only.

Update README.md #16

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Update README.md #16

merged 1 commit into from
Jul 3, 2019

Conversation

flip111
Copy link
Contributor

@flip111 flip111 commented Jul 3, 2019

This PR partially replaces #6 Also added a second GUI library. And the PR uses the template in the readme.

@flip111 flip111 requested a review from a team as a code owner July 3, 2019 18:30
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Jul 3, 2019
@jacobrosenthal
Copy link

There is one existing library to build on, https://github.com/jamwaffles/embedded-graphics

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for writing it up.

@therealprof therealprof merged commit be9c258 into rust-embedded:master Jul 3, 2019
@flip111
Copy link
Contributor Author

flip111 commented Jul 3, 2019

There is one existing library to build on, https://github.com/jamwaffles/embedded-graphics

@jacobrosenthal do you think we should mention that? I had a look at the readme, it seems to be for raw graphics and doesn't provide a toolkit with GUI elements. Maybe all that is needed is to reword the sentence i wrote a bit not to exclude this library from the wording ?

@jacobrosenthal
Copy link

jacobrosenthal commented Jul 3, 2019 via email

@jamwaffles
Copy link

it seems to be for raw graphics and doesn't provide a toolkit with GUI elements.

Correct, however one of my hopes is that it will be a library useful enough to build an embedded-ui crate on top of. I've had that in mind for a while, but haven't had a need for a UI library so never started one. I'm interested to see what people come up with!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants