Skip to content
This repository was archived by the owner on Jul 1, 2025. It is now read-only.

Add usb-device and stm32f103xx-usb WIP crates #15

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Conversation

Disasm
Copy link
Member

@Disasm Disasm commented Apr 2, 2019

Thanks for submitting!

Category

Is this PR a:

  • New Not Yet Awesome item?
  • A WIP project addressing an open item?
  • Removing a Not Yet Awesome item?

New Not Yet Awesome item checklist

  • Is the request clearly stated, linking to relevant documentation, such as a whitepaper, protocol definition, datasheet, etc.?
  • Are the "Success Criteria" defined?
  • Is this request possible using today's Rust (not blocked by LLVM impl, rustc impl, etc.)?
  • Is this request broken into reasonable work packages, such as "Create HAL for XYZ chip", not "support all boards from ABC vendor"?

WIP Project checklist

  • Is there a link to the source project on GitHub/GitLab/etc?
  • Is the project open source?
  • Is it clear if contributions are welcome?
  • Is the project relevant to the TODO item it addresses?
  • Is the project more than just an empty repo or a placeholder (e.g. just a "hello world" bin.rs/lib.rs)?

Remove an item checklist

  • Has the project that fixes the item been mentioned in the PR?
  • Does the project address the original request fully?
  • Has the crate that addresses the request has been added to the Awesome Embedded Rust list?
  • Has the crate has been published on crates.io (or somewhere else where other people can consume it)?

@Disasm Disasm requested a review from a team as a code owner April 2, 2019 20:27
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Apr 2, 2019
@thejpster
Copy link
Contributor

LGTM. Author seems to be interacting on Github regarding issues and changes, so happy to waive the unticked box.

@thejpster thejpster merged commit f2e6f93 into master Apr 2, 2019
@bors bors bot deleted the Disasm-patch-1 branch April 2, 2019 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants