Skip to content

Update the spidev documentation links #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Update the spidev documentation links #37

merged 1 commit into from
Mar 17, 2020

Conversation

gszy
Copy link
Contributor

@gszy gszy commented Mar 17, 2020

There were two links in the doc comments (of the Spidev struct and the Spidev::open() method) that guided to the documentation of the old (0.3.0) version of the spidev crate. This patch updates those links to direct to the new version (0.4.0, the same as this crate depends on).

There were two links in the doc comments (of the Spidev struct and the
Spidev::open() method) that guided to the documentation of the old
(0.3.0) version of the spidev crate. This patch updates those links to
direct to the new version (0.4.0, the same as _this_ crate depends on).
@gszy gszy requested a review from a team as a code owner March 17, 2020 20:12
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Review is incomplete T-embedded-linux labels Mar 17, 2020
@ryankurte
Copy link
Contributor

thanks for the PR! lgtm (though unfortunate there doesn't seem to be a way to link against the dependency version in docs.rs)

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 17, 2020

👎 Rejected by too few approved reviews

@ryankurte
Copy link
Contributor

oops

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 17, 2020

Build succeeded

@bors bors bot merged commit bc3d0cb into rust-embedded:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Review is incomplete T-embedded-linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants