Implements TryFrom for Deque from array #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgued
requested changes
Aug 19, 2025
sgued
previously approved these changes
Aug 22, 2025
hicklin
force-pushed
the
impl_try_from_for_deque
branch
2 times, most recently
from
5a5388d to
63e9a67
Compare
sgued
reviewed
Sep 8, 2025
hicklin
force-pushed
the
impl_try_from_for_deque
branch
from
63e9a67 to
73d8fa2
Compare
hicklin
force-pushed
the
impl_try_from_for_deque
branch
from
73d8fa2 to
75dbe63
Compare
sgued
approved these changes
Sep 8, 2025
zeenix
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous reviews and comments can be found in pull request 524.
Fixes #522.
This PR implements the TryFrom trait for creating a Deque from a slice.
Note the use of unsafe for copying all bytes from the slice to the Deque buffer after ensuring that the Deque buffer has enough space.
Also note the use of ManuallyDrop to ensure that any heap memory referred to by the element contents is not dropped at the end of this method since the elements in the Deque buffer will be pointing to it.